-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TreeView): support additional navigation and selection behavior #11328
feat(TreeView): support additional navigation and selection behavior #11328
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those on mac with keyboards without the home/end key:
Home = fn + left arrow
End = fn + right arrow
https://support.apple.com/en-us/HT201236
So the full sequence that worked for me was fn + shift + left/right arrow
4f0f8d1
to
ca3f006
Compare
Home/End navigation is a good addition. However, Shift+Home is not a key I've ever heard used in a tree context before. I'm not even sure I've heard of it used in a select element. I have seen Ctrl+Sh+Home/End in a select, but not in a tree. So I do question you introducing this key combination. It doesn't seem to be in the APG. |
@mbgower shift + home/end seems standard for file browser contexts, so I included that originally. I have now updated it to ctrl + shift + home/end to match the suggestions in the APG |
3702c2a
to
202b813
Compare
202b813
to
253375f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
…arbon-design-system#11328) * feat(TreeView): implement `Home` and `End` key navigation * feat(TreeView): support Shift + `Home` and `End` multiselection * feat(match): support `event.code` matching * feat(TreeView): add `ctrl + A` selection * chore: add arm64 build artifacts * fix(TreeView): update shift + home/end shortcut Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Related #6792
This PR adds preliminary support for Home and End navigation as well as Shift + Home/End and Ctrl + A selection according to the tree view APG
additional testing will be done to confirm the selection model for different platforms and operating systems
Changelog
New
Changed
event.code
inmatch
utility functionTesting / Reviewing